-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stefan Sperling wrote:
[..]
> You're correct, the place you point out is the place where my_bc_url
> is initialised. If we could canonicalise it right there without causing
> breakage elsewhere (make check over ra_neon should tell us) then please
> send an updated patch. I'd say if changing this ends up causing breakage
> we can apply your original patch, and then try to fix the breakage and
> canonicalise my_bc_url earlier in a separate patch.
Thank you Stefan. `apr_hash_get()' returns a struct comprising of two
values(data, len), of which we need to canonicalise 'data' to store it
in `my_bc_url'. So, canonicalisation right there fails (AFAICS).
Attaching the updated original patch herewith.
[[[
Log:
Make a proper fix to resolve some deprecation warnings using
`svn_path_url_add_component2()' by canonicalizing the base before
passing to the above method.
[in subversion/libsvn_ra_neon]
* commit.c
(get_version_url, create_activity, commit_add_dir, commit_add_file
commit_close_file, add_child, commit_delete_entry): Use
`svn_path_url_add_component2()'.
(svn_ra_neon__get_commit_editor, checkout_resource, apply_revprops):
Canonicalize the base before passing to
`svn_path_url_add_component2()'.
* props.c
(svn_ra_neon__get_baseline_info): Canonicalize the base before
passing to `svn_path_url_add_component2()'.
Found and Suggested by: stsp
Patch by: Kannan R <kannanr_at_collab.net>
]]]
- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSx3u33lTqcY7ytmIAQLkpgf/Ye/v0jRCE65QFxYh5dr/oR5n/DoijIhO
fVVzsu/k9Cc/6SuKbCg6eCPr9rHaDRVvBCQy+kOHC3HYyNOdv37wUT0LGqc94LHg
RVyTq4R9EcIBFB05z3C7OD3UWso6ngaOteUD4+fe/PvPql51GiqQ+gPKzpmiZaJN
23IN13gadZOXg8079N6yLv1ui+9OIG8i3UQ4ON9v6s5h8+euxMYv2A3qe6pjVaW6
qXZKuAiL4/Qj7YMfOtEG7rmNsGtbukPFJ2kZ7p+Xu9B13Bxv2tOaGohlVf31Ypj7
fJKiKunAbGJM4mN6L/cwlnQHIWIxSMvNzEex9ULkCym0AUTZrxtuHA==
=d3CC
-----END PGP SIGNATURE-----
Received on 2009-12-08 07:17:54 CET