Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote:
> What's the benefit of this change?

Speaking for myself... it's clearly just a tiny code improvement. +1.

I thin it is also more consistent with the way such checks are done in
other svn_client functions.

- Julian

> Kannan wrote on Fri, 4 Dec 2009 at 23:06 +0530:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> >
> > Log:
> > Instead of using a separate bool variable, use `svn_path_is_url()'.
> >
> > * subversion/libsvn_client/log.c
> > (svn_client_log5): Remove the bool variable `is_url' which is used only
> > once and substitute with `svn_path_is_url(path)'.
> >
> > Patch by: Kannan R <kannanr_at_collab.net>
Received on 2009-12-04 18:55:07 CET