Re: [PATCH][RFC] allow local file:// URLs for svnadmin

On Dec 4, 2009, at 6:50 AM, Julian Foad wrote:

> Vincent Legoll wrote:
>> Hello,
>>
>> would such kind of patch be acceptable or is this useless ?
>>
>> I think there's nothing preventing svnadmin to accept local
>> file:// URLs as repository location parameter. So why not ?
>
> Let me ask a different question: Why? (We don't add features just
> because we can, we add them because they are useful enough to be worth
> the maintenance.)
>
> I can think of a reason: it could be handy to copying URLs between "svn"
> and "svnlook" and "svnadmin" commands. Is that your reason? Is there any
> stronger reason? Would you add it to svnlook as well?
>
> If you want to do this, remember that converting a URL to a local path
> is not as simple as stripping off a prefix: there are at least two
> different prefixes (file://localhost as well), and you have to un-escape
> the URL escaping.

My initial reaction is about consistency. I can't think of any place we accept URLs as parameters to svnadmin, and I'm really hesitant to start doing so. In the command-line client, when we say "URL" we mean *any* well-formed URL, not just those with a specific access method. Changing that meaning on any of the command-line tools is inconsistent, and should be avoided.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2427073

Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.
Received on 2009-12-04 16:14:23 CET