Re: [PATCH] Handle special characters in Junit report

On Fri, 2009-12-04 at 14:44 +0000, Julian Foad wrote:
> Sure. The idea is to make the occasional unexpected control character
> appear as something that is valid in an XML CDATA section and is
> human-readable. URL escaping rules seemed a fine choice. Have I missed
> something?
>
> > > Incorporated the above suggestion and committed in r887178.
> >
> > Wait, you committed a script that does URL quoting on XML contents?
> Did
> > you look at the output?
>
> I didn't look at any real output, only a hand-crafted test string. Did
> you? Why do you ask?

Here's the real output.
  -- prop_tests.py.junit.xml.invalid -- before this patch
  -- prop_tests.py.junit.xml.valid -- after this patch

To verify the case with "]]>" pattern, you can edit the tests.log file
with this pattern in any one of failure message. If you run the script,
without this patch, it will generate an invalid xml file. With this
patch, it will generate a valid xml file.

-- 
Bhuvaneswaran A    
CollabNet Software P Ltd.  |  www.collab.net