[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Extend error message for url demanding wc rev, to all subcommands

From: Kannan <kannanr_at_collab.net>
Date: Fri, 04 Dec 2009 17:13:50 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

At present when invalid revision keywords (BASE|PREV|COMMITTED) are used
with a URL, svn gracefully errors out only for four subcommands (merge,
diff, copy, log AFAIK) as of now. This patch extends to other
subcommands too, by having the error message in a common spot.

[[[
Log:
Make svn error out gracefully when invalid revision
keywords(BASE|PREV|COMMITTED) are used with a URL, hereby extending to
all subcommands. Previously it was handled gracefully only for merge,
diff, copy, log.

* subversion/libsvn_client/revisions.c
 (svn_client__get_revision_number): If the incoming path is a URL
  demanding a wc revision argument, error out gracefully.

* subversion/libsvn_client/ra.c
 (svn_client__repos_locations): Rename `local_abspath' to
  `local_abspath_or_url' as it holds either a wc abs-path or a URL and
  reflect the other changes accordingly.

* merge.c
 (normalize_merge_sources): Remove the redundant code.

* diff.c
 (check_paths): Same.

* log.c
 (svn_client_log5): Same.

* copy.c
 (try_copy): Same.

Patch by: Kannan R <kannanr_at_collab.net>
]]]

P.S: Part of the changes made in ra.c and merge.c, is also submitted in
[1]. This patch extends the same.

[1]-http://mail-archives.apache.org/mod_mbox/subversion-dev/200912.mbox/<4B1678AC.9090403@collab.net>

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSxj19nlTqcY7ytmIAQJNGQf/WjSCig+DRFOwQrf289NfnSs6o/h4+dwI
mR8S9VamLHSkTcqvAI0Uf3LqSZqAUFY1eN24VL1P0o6TzNy+cq2sV6JczIIb2p6D
uayleu1qwW0YAVVOcKHwEKq28GLufTBl1/18nK+S+nYwHzTUAUnDUGuh5j1qkECJ
M14QmIsvzsq38hpX/2Xp8tT2QWMV7FGLsYHEeZVBCggtJZ0mOY1TYhQQYeipfzp4
SpmV9eW+G61btVyjSC5eyJ0cgy3Ju3AMIs5PVGpYR5iHbUOajSSOgGtZzD8gAIMk
AxgdpE+7ZPkTXJbaNWAwUq2hfDOn7L0BJKmhkOj1zoGyO7PB6LP7LQ==
=VJ9J
-----END PGP SIGNATURE-----

Received on 2009-12-04 12:46:18 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.