[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Enhancing mailer.py for email-based issue trackers

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 30 Nov 2009 17:31:16 +0000

Vallon, Justin wrote:
> Gladly.
>
> Log message:
>
> Add parameter "search_logmsg=REGEXP" to allow filtering based on contents
> of log message.

Sorry, I didn't notice you are new to the project. We have a log message
policy that describes, after the introduction, what changes were made in
each file. The log message policy (in three pages of excruciating
detail) is here:
<http://subversion.tigris.org/hacking.html#log-messages>.

We don't expect new contributors to do all of that first time, so I'll
do it.

[[[
Extend "mailer.py" with an option "search_logmsg=REGEXP" to allow filtering
based on matching expressions in the log message such as bug id's.

Patch by: Justin Vallon <justin.vallon{_AT_}deshaw.com>

* tools/hook-scripts/mailer/mailer.conf.example
  Add documentation and an example of the new configuration options.

* tools/hook-scripts/mailer/mailer.py
  (Commit): Pass the log message to the which_groups() call.
  (PropChange, Lock): Pass no log message to the which_groups() call.
  (Config): Parse the new option and extend the which_groups() function
    to include groups specified through matching the log message.

* tools/hook-scripts/mailer/tests/mailer.conf
  (bugtracker): New section with the new configuration options.

* tools/hook-scripts/mailer/tests/mailer-init.sh
  Put some example bug id's into some of the commit messages.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Adjust for the additions and changes to the expected output.
]]]

After all that, I have committed it in r885511.

Thank you very much for the enhancement!

- Julian

> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: Monday, November 30, 2009 6:36 AM
> To: Vallon, Justin
> Cc: dev_at_subversion.tigris.org; Edmund Wong; Jon Bendtsen; Lars Gullik BjĂžnnes
> Subject: Re: Enhancing mailer.py for email-based issue trackers
>
> On Mon, 2009-11-30, I (Julian Foad) wrote:
> > I am reluctant to commit something I haven't tried out and reviewed, and
> > can't spend the time on this one, but it looks "safe" in the "do no
> > harm" and "is a reasonable direction of progress" senses so shall I just
> > commit it?
> >
> > Yes, I shall commit it, unless anyone quickly lets me know otherwise.
>
> D'oh, there's no log message.
> <http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2420301>
>
> I could write one myself, given time, but it would really help me if you
> could provide one.
>
> - Julian
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2425493
>
> Please start new threads on the <dev_at_subversion.apache.org> mailing list.
> To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2425591

Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.
Received on 2009-11-30 18:31:38 CET

This is an archived mail posted to the Subversion Dev mailing list.