[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] gpg-agent support

From: Dan Engel <dan_at_sourceharvest.com>
Date: Wed, 25 Nov 2009 19:29:15 -0500

All,

I hope you will forgive any breach in protocol or etiquette in this
submission. This is my first post. I tried to read and follow the
guidelines, but there really are a lot of them!

This code is a first cut (well, an in-use first cut). I developed it
specifically for use at work, but once it was up and running I decided
to follow through and turn it into a patch submission.

There are definitely more efficient ways to do some of what's in here,
and I'll eventually get around to figuring them out if someone else
doesn't do so first; in the meantime, there may be others who would
benefit from this functionality.

I also didn't like having to modify the simple_provider_helper function
with special handling for the GPG_AGENT password type, but it seemed
like there was some special GNOME_KEYRING code in that same file (in the
save_creds helper function). If that was the wrong way to go about this,
then I'd welcome some better instruction.

I'm not sure whether the save function is even necessary (password_set).
It just returns true. It seems that at one point while I was trying to
get things to work correctly, I concluded that it was necessary to take
that step.

I hope this log is detailed/inclusive enough.

[[[
Add GPG-AGENT support for Subversion password handling.

* Makefile.in
  Include support for building libsvn_auth_gpg_agent.

* build.conf
  Include support for building libsvn_auth_gpg_agent.

* configure.ac
  Include support for configuring a build to include gpg-agent support.

* subversion/include/private/svn_auth_private.h
  Add password type #define for gpg-agent type.

* subversion/include/svn_auth.h
  Add declarations of functions provided by libsvn_auth_gpg_agent
library.

* subversion/libsvn_auth_gpg_agent/gpg_agent.c
  Password handling functions for gpg-agent password store.

* subversion/libsvn_auth_gpg_agent/version.c
  Provide version information for libsvn_auth_gpg_agent.

* subversion/libsvn_subr/auth.c
  Add gpg-agent to the list of password store types supported.

* subversion/libsvn_subr/simple_providers.c
  Add some special handling for gpg-agent type password.
]]]

Thanks!

-Dan Engel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2424464

Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.

Received on 2009-11-26 05:26:49 CET

This is an archived mail posted to the Subversion Dev mailing list.