[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnserve: pre-lock arguments like &

From: <svn-sth_at_mnet-online.de>
Date: Tue, 24 Nov 2009 15:56:20 +0100

Zitat von Branko ─îibej <brane_at_xbc.nu>:

Hi,

first of all THX for your fast Feedback and sorry for wasting your time.
(ps: at the user list there was not feedback at all :( )

The hook-script itself was working perfect, but we use a XML based hooks-
system, where all repo. have the same global hooks, reading a xml file
based on the hook-subscrition of the rep in the xml the corresponding
hook is started, and there was the error during the handover of the
params to the finally started script.

kind regards,
sth.

> Julian Foad wrote:
>> Philip Martin wrote:
>>
>>> svn-sth_at_mnet-online.de writes:
>>>
>>>> so i assume that svnserve is not starting the hook with right parameters,
>>>> i also assume that it is more like:
>>>>
>>>> /bin/sh -c ... $1 $2 $3
>>>>
>>>> instead of:
>>>>
>>>> /bin/sh -c ... "$1" "$2" "$3"
>>>>
>>>> can someone confirm on that.
>>>>
>>> Your question should really be directed to the users mailing list. It
>>> would help if you included the failing script.
>>>
>>> To answer your question: Subversion doesn't invoke a shell; it execs
>>> the hook directly.
>>>
>>
>> FWIW I tested with 1.6.5 and trunk_at_883366, with a "#!/bin/sh" pre-lock
>> hook, and the file name 'amazing space&ampersand' was passed correctly
>> as a single parameter.
>>
>
> Yup, sure. Problems begin when you try to do anything with such a
> parameter and forget about properly quoting the expansion.
>
> -- Brane
>
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2423840

Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.
Received on 2009-11-24 15:56:40 CET

This is an archived mail posted to the Subversion Dev mailing list.