On Thu, 2009-11-12, Kannan wrote:
> Hyrum K. Wright wrote:
> > On Nov 12, 2009, at 5:53 AM, Julian Foad wrote:
> >> Stefan Sperling wrote:
> >>> On Thu, Nov 12, 2009 at 11:01:10AM +0000, Julian Foad wrote:
> >>>> We try hard not to change the output format. Why do we need to change it
> >>>> here? The other subcommands manage to convert abs paths back to rel
> >>>> paths for display.
> >>> How? Can you show an example?
> >> I'm sure I recall somebody mentioning on dev@ that they did this for at
> >> least one other command earlier this year.
> >>
> >> A search for "to_rel" finds info_receiver_relpath_wrapper() which is
> >> undocumented, aargh, but looks like it does that sort of thing.
> >>
> >> Basically you just have to know what your base path is, transfer it
> >> (through a baton if necessary) to the output function, and strip it off
> >> the received abspath (making sure the base path is in canonical absolute
> >> form as well).
>
> If we're to use info_receiver_relpath_wrapper() and a baton to pass the
> relative path and other info, won't it resemble the implementation(for
> backward compatibility)which is at present?
Kannan,
I'm sorry, I don't understand that question. What will resemble what
implementation, in what way?
> > FWIW, centralization and sanitization of relative path output in an
> absolute path world is issue 3464:
> > http://subversion.tigris.org/issues/show_bug.cgi?id=3464
>
> Thank you Hyrum, in that case implementing using a separate wrapper(now)
> for info alone becomes obsolete right?
Do you mean "I can change the output format (from relative to absolute)
now, because there is an issue filed for fixing that (changing it back
to relative) later" ? If so, I disagree.
We COULD apply this patch now, if people think that is the best thing to
do, but I am concerned that if we start making changes like this, we may
not implement the necessary infrastructure to make it easy to "fix" it
later, and also we may start to lose track of what user-visible changes
we have made. If we do it properly straight away, then we will know we
are on track.
So if you can, please find a way to keep the output format the same, and
you get bonus points if you can create a shared function to help do
that.
Thanks.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2423354
Please start new threads on the <dev_at_subversion.apache.org> mailing list.
To subscribe to the new list, send an empty e-mail to <dev-subscribe_at_subversion.apache.org>.
Received on 2009-11-23 15:07:20 CET