[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v3] Fix failing three way diff for properties

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 11 Nov 2009 18:40:44 +0000

On Wed, 2009-11-11 at 19:34 +0100, Stefan Sperling wrote:
> On Wed, Nov 11, 2009 at 06:53:52PM +0100, Daniel Näslund wrote:
> > Formatting of long lines can be difficult. Is this ok?
> >
> > [[[
> > new_conflict->mime_type = conflict->mime_type
> > ? apr_pstrdup(result_pool, conflict->mime_type)
> > : NULL;
> > ]]]
>
> I'd mildly prefer:
>
> [[[
> new_conflict->mime_type = conflict->mime_type ? apr_pstrdup(
> result_pool,
> conflict->mime_type)
> : NULL;
> ]]]

I prefer an olive shade of green:

> new_conflict->mime_type
> = conflict->mime_type ? apr_pstrdup(conflict->mime_type) : NULL;

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416688
Received on 2009-11-11 19:41:03 CET

This is an archived mail posted to the Subversion Dev mailing list.