[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove warning 'format not a string literal' in libsvn_client

From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Wed, 11 Nov 2009 19:39:32 +1100

Great news - thanks Daniel.

Gavin.

On 11/11/2009, at 17:34 , Daniel Näslund wrote:

> Hi Gavin!
>
> This one has already been submitted. r40389
>
> On Wed, Nov 11, 2009 at 10:11:45AM +1100, Gavin 'Beau' Baumanis wrote:
>> Hi Daniel,
>>
>> Just checking to see if you're doing any more work with this patch
>> submission?
>>
>> Gavin.
>>
>>
>> On 06/11/2009, at 05:57 , Daniel Näslund wrote:
>>
>>> On Thu, Nov 05, 2009 at 07:18:29PM +0100, Branko Cibej wrote:
>>>> Peter Samuelson wrote:
>>>>> [Daniel Näslund]
>>>>>
>>>>>> if (! original_value)
>>>>>> - header_fmt = _("Added: %s%s");
>>>>>> + SVN_ERR(file_printf_from_utf8(file, encoding, "Added: %s
>>>>>> %s",
>>>>>> + propchange->name,
>>>>>> APR_EOL_STR));
>>>>>>
>>>>>
>>>>> Julian talked about this code already, but just to point out: your
>>>>> change is incorrect, because it removes the _() functionality, i.e.,
>>>>> string localisation. You have to be careful about these things.
>>>>>
>>>>> ...Indeed, we use quite a lot of _() with printf format strings (see
>>>>> all the references to 'c-format' in tools/po/po-update.sh). Why
>>>>> aren't these _all_ warnings with your compiler?
>
> [...]
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416403

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416420
Received on 2009-11-11 09:40:03 CET

This is an archived mail posted to the Subversion Dev mailing list.