Re: [PATCH] Fix some deprecation warnings

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
> On Tue, 2009-11-10 at 19:34 +0530, Kannan wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Julian Foad wrote:
>>> The value of "fs_path" there comes from
>>> svn_client__path_relative_to_root(..., include_leading_slash=TRUE) which
>>> says, "Return the path of ABSPATH_OR_URL relative to the repository root
>>> (REPOS_ROOT) in REL_PATH (URI-decoded)".
>>>
>>> The dirent_uri API defines "relpath" as never having a leading slash, so
>>> we can't use svn_relpath_join(). The API does not specify whether a
>>> "uri" is URI-encoded, so we suppose we can use svn_uri_join().
>>>
>>> I think that way of using the APIs is not ideal, but it will do for now.
>> Thank you for the clarification, Julian.
>>>> And for
>>>> the other case(from your comments) use svn_dirent_join() as it points
>>>> only to local absolute paths, or I'm still not getting you?. But the
>>>> 'ls' tests seem to pass for me for the patch I sent, which is odd?
>>> Not sure what "other case" you are referring to.
>> Sorry for the brevity. Referred to the change to svn_uri_join() in the
>> "if" block of the same patch.
>
> Index: subversion/libsvn_client/list.c
> ===================================================================
> --- subversion/libsvn_client/list.c (revision 40358)
> +++ subversion/libsvn_client/list.c (working copy)
> @@ -86,11 +86,11 @@
>
> svn_pool_clear(iterpool);
>
> - path = svn_path_join(dir, item->key, iterpool);
> + path = svn_relpath_join(dir, item->key, iterpool);
>
> if (locks)
> {
> - const char *abs_path = svn_path_join(fs_path, path,
> iterpool);
> + const char *abs_path = svn_uri_join(fs_path, path, iterpool);
> lock = apr_hash_get(locks, abs_path, APR_HASH_KEY_STRING);
> }
> else
>
> That "if" block? But that's the one we have been talking about, since
> Dan Rall asked "Why use svn_uri_join() rather than svn_dirent_join()?"
> in this message:
> <http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415197>.

Oops, thought you answered for the svn_relpath_join()! So, the
svn_relpath_join() is fine then? (Bit confused)

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvmFinlTqcY7ytmIAQKzgAf/bEU/eqmUAiKnCC9tBGxAE8N2pVboSavE
GplpxkK3maM47QAucZi+K/zlO4Yqk1BrpzGCcbiamb6GpjRqQNJKgSGm6o/aFP/b
XJoWU7MKucSlTavXCmEQ6hLLQqFLIk23Mxuma4suzlQrn9sYtrMZBv5M8EdC60Lr
hbM+o+ZDKvN0TFjYQCJWUd0Q2wP19lEQqF/AVwz8Q4SFRLCiSVMWbq25N9pLaImo
WWo++ppPTY54pICXik8lvDzqoowKGWCFkxW4XxpieT6rM32H9PRdmt8rQ2c4ZFPh
9qgtIDeJUUExy8hbECn8GkIFF6Kz9fB6bDvZTgWtWSzqzO/LZ54zxg==
=kjy2
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416178