[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Kannan <kannanr_at_collab.net>
Date: Tue, 10 Nov 2009 19:34:47 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
> The value of "fs_path" there comes from
> svn_client__path_relative_to_root(..., include_leading_slash=TRUE) which
> says, "Return the path of ABSPATH_OR_URL relative to the repository root
> (REPOS_ROOT) in REL_PATH (URI-decoded)".
>
> The dirent_uri API defines "relpath" as never having a leading slash, so
> we can't use svn_relpath_join(). The API does not specify whether a
> "uri" is URI-encoded, so we suppose we can use svn_uri_join().
>
> I think that way of using the APIs is not ideal, but it will do for now.

 Thank you for the clarification, Julian.
>> And for
>> the other case(from your comments) use svn_dirent_join() as it points
>> only to local absolute paths, or I'm still not getting you?. But the
>> 'ls' tests seem to pass for me for the patch I sent, which is odd?
>
> Not sure what "other case" you are referring to.

Sorry for the brevity. Referred to the change to svn_uri_join() in the
"if" block of the same patch.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvly/3lTqcY7ytmIAQJZXgf7BMnN24SDHZizZWe8nmbzbtAuBbASuXAk
TCyQ+hEXiH/KjPidTv4oXN9uAJID5YsLYTznNzU7dUl5a4dDuTWH1FnoLXlOp43c
O7LynGcA430/+Zeqx3HUTCmcOvMEFE1Aaqb73kYWMB790sYJ5GUVxGqZ3F6F69/N
7EvuMmDN+QPI+GdEI7N5/D3tBaDmoA+JxtFxX8U/ERSd1a86Iz7332POps0v9n/t
M82b4X5ZdAmNdjCAbxg1J7I36Mc8io+xXql0ad4r2G+cTBZm4XukR467Sqw0J7RC
BqtO15MMoYc/cMP8kheTfKtUZ7RPmYpJBdUYT33wZNkhWZVw7QTq+A==
=hjD7
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416149

Received on 2009-11-10 15:07:00 CET

This is an archived mail posted to the Subversion Dev mailing list.