Yeah. I figured the #ifdef SVN_DEBUG around it would have been enough.
But sure... maybe it wasn't clear that it was a "safe" commit of
SVN_DBG(). Some extra commentary could be added to explain. I'll wait
to see what Arfrever would like to do here before jumping in.
Cheers,
-g
On Mon, Nov 9, 2009 at 17:26, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> As Hyrum said in another thread, until now I had the impression that
> SVN_DBG should "never" be committed. Perhaps Arfrever had the same
> impression...
>
> Daniel
> (who just two days ago removed an instance of SVN_DBG() he had been
> too lazy to replace by proper printf() before)
>
> Greg Stein wrote on Mon, 9 Nov 2009 at 08:44 -0500:
>> Why did you revert my change?
>>
>> I used SVN_DBG() *specifically* so that we would get proper formatting
>> of the error messages. You just broke that. Explain.
>>
>> -g
>>
>> On Sun, Nov 8, 2009 at 16:29, Arfrever Frehtes Taifersar Arahesis
>> <Arfrever.FTA_at_gmail.com> wrote:
>> > Author: arfrever
>> > Date: Sun Nov 8 13:29:36 2009
>> > New Revision: 40422
>> >
>> > Log:
>> > * subversion/libsvn_subr/dso.c
>> > (svn_dso_load): Use fprintf() instead of SVN_DBG() to print error message.
>> >
>> > Modified:
>> > trunk/subversion/libsvn_subr/dso.c
>> >
>> > Modified: trunk/subversion/libsvn_subr/dso.c
>> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/dso.c?pathrev=40422&r1=40421&r2=40422
>> > ==============================================================================
>> > --- trunk/subversion/libsvn_subr/dso.c Fri Nov 6 21:30:40 2009 (r40421)
>> > +++ trunk/subversion/libsvn_subr/dso.c Sun Nov 8 13:29:36 2009 (r40422)
>> > @@ -107,7 +107,7 @@ svn_dso_load(apr_dso_handle_t **dso, con
>> > {
>> > #ifdef SVN_DEBUG
>> > char buf[1024];
>> > - SVN_DBG(("%s\n", apr_dso_error(*dso, buf, 1024)));
>> > + fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
>> > #endif
>> > *dso = NULL;
>> >
>> > ------------------------------------------------------
>> > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2415614
>> >
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415783
>>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415946
Received on 2009-11-09 23:52:57 CET