[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40424 - trunk/subversion/libsvn_wc

From: Edmund Wong <ed_at_kdtc.net>
Date: Mon, 09 Nov 2009 10:34:55 +0800

Branko ─îibej wrote:
>
> It's quite simple. In the 1990 version of C, unline in C++, you cannot
> arbitrarily mix variable declarations and statements; all declarations
> must come before the first statement. C99 removes this restriction.
> GCC's default is closer to C99. Microsoft's compilers do not support C99
> (at all). I'm constantly astounded at how many "C programmers" are not
> aware of that.
>
> Our hacking guidelines sort of imply that we're restricted to C90,
> though they're not explicit, unfortunately. Should be amended ...

Thanks Branko for the quick clarification.

That explains it; but, what it doesn't explain is why it doesn't
complain with the check_tree_conflict() (which is the next
function after get_node_uri() which has the following:

   svn_wc_conflict_reason_t reason = SVN_WC_CONFLICT_REASON_NONE;
   svn_boolean_t all_mods_are_deletes = FALSE;
   svn_wc_conflict_reason_t possible_conflict_reason;
   svn_node_kind_t kind;

Yet VS2008 compiles it ok. I'm baffled with VS2008's (in)consistency.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415655
Received on 2009-11-09 03:47:11 CET

This is an archived mail posted to the Subversion Dev mailing list.