[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: Fri, 6 Nov 2009 11:02:23 -0800

On Wed, Nov 4, 2009 at 1:35 AM, Kannan <kannanr_at_collab.net> wrote:
...
> Resolve some deprecation warnings.
>
> * subversion/libsvn_client/list.c
>  (get_dir_contents): Use `svn_relpath_join()' and `svn_uri_join()'.

Index: subversion/libsvn_client/list.c
===================================================================
--- subversion/libsvn_client/list.c (revision 40358)
+++ subversion/libsvn_client/list.c (working copy)
@@ -86,11 +86,11 @@

       svn_pool_clear(iterpool);

- path = svn_path_join(dir, item->key, iterpool);
+ path = svn_relpath_join(dir, item->key, iterpool);

       if (locks)
         {
- const char *abs_path = svn_path_join(fs_path, path, iterpool);
+ const char *abs_path = svn_uri_join(fs_path, path, iterpool);
           lock = apr_hash_get(locks, abs_path, APR_HASH_KEY_STRING);
         }
       else

get_dir_contents() documents "fs_path" as "the absolute filesystem
path of the RA session". The "locks" input parameter's value appears
to always come from svn_ra_get_locks(), which also indicates that its
output hash contains keys which are "absolute fs paths".

1) Is one of these doc strings wrong (meaning that one of the paths is
relative)?

2) Why use svn_uri_join() rather than svn_dirent_join()?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415197
Received on 2009-11-06 20:02:32 CET

This is an archived mail posted to the Subversion Dev mailing list.