[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v2] Remove warning 'format not a string literal' in libsvn_client

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 05 Nov 2009 19:04:16 +0000

Daniel Näslund wrote:
> On Thu, Nov 05, 2009 at 11:19:37AM +0000, Julian Foad wrote:
> [[[
> * subversion/libsvn_client/diff.c
> (display_prop_diffs): Remove warnings about 'format not a string
> literal'.
>
> * subversion/libsvn_client/export.c
> (copy_one_versioned_file): Remove warnings about 'format not a string
> literal'.
>
> Patch by: Daniel Näslund <daniel_at_longitudo.com>
> Julian Foad
> ]]]
[...]
> That was so much better. Very few lines in the previous patch but I
> managed to screw up a couple of localisation strings and do some heavy
> code duplication. Not bad.
>
> I've run the export_tests and diff_tests. They pass.

Thanks! Committed revision 40389.

I tried to write the log message in a way that doesn't imply that
removing warnings is the "be-all and end-all" of why we want this
change. In other words, the warnings gave us a hint that we might like
to make an improvement to our code, but we made the change because it is
an improvement, not just because it stops the warnings from appearing.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414883
Received on 2009-11-05 20:04:41 CET

This is an archived mail posted to the Subversion Dev mailing list.