[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove warning 'format not a string literal' in libsvn_client

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 5 Nov 2009 18:46:52 +0100

On Thu, Nov 05, 2009 at 05:37:46PM +0000, Julian Foad wrote:
> Peter Samuelson wrote:
> > ...Indeed, we use quite a lot of _() with printf format strings (see
> > all the references to 'c-format' in tools/po/po-update.sh). Why
> > aren't these _all_ warnings with your compiler?
>
> Peter,
>
> The warnings are nothing to do with _() but only to do with passing a
> variable as the format argument to a printf(), which makes the compiler
> unable to check the format.

And passing a variable as a format string is always wrong, isn't it?

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414832
Received on 2009-11-05 18:47:13 CET

This is an archived mail posted to the Subversion Dev mailing list.