[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40340 - trunk/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 2 Nov 2009 08:35:39 -0600

On Nov 2, 2009, at 8:12 AM, Branko ─îibej wrote:

> Hyrum K. Wright wrote:
>> On Nov 1, 2009, at 8:27 AM, Bert Huijben wrote:
>>
>>> if (val)
>>> - entries_format = (apr_off_t)apr_strtoi64(val, NULL, 0);
>>> + entries_format = (int)apr_strtoi64(val, NULL, 0);
                                    A
                         space here |

>>>
>>
>> I know the old code didn't do this, but I think the trend is to use
>> space-before-paren for casts. (But it's part of old-and-busted, so I
>> don't really think it matters that much. Vermillion.)
>>
>
> Eh, I'm confuse, space before _which_ paren?

Heh, I guess that line does look a bit lispy.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413808
Received on 2009-11-02 15:35:55 CET

This is an archived mail posted to the Subversion Dev mailing list.