[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40340 - trunk/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 2 Nov 2009 06:45:48 -0600

On Nov 1, 2009, at 8:27 AM, Bert Huijben wrote:

> Author: rhuijben
> Date: Sun Nov 1 06:27:25 2009
> New Revision: 40340
>
> Log:
> * subversion/libsvn_wc/old-and-busted.c
> (svn_wc__read_entries_old):
> Cast format number to integer instead of unrelated type to
> remove warning.
>
> Modified:
> trunk/subversion/libsvn_wc/old-and-busted.c
>
> Modified: trunk/subversion/libsvn_wc/old-and-busted.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/old-and-busted.c?pathrev=40340&r1=40339&r2=40340
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- trunk/subversion/libsvn_wc/old-and-busted.c Sun Nov 1 06:12:56
> 2009 (r40339)
> +++ trunk/subversion/libsvn_wc/old-and-busted.c Sun Nov 1 06:27:25
> 2009 (r40340)
> @@ -1242,7 +1242,7 @@ svn_wc__read_entries_old(apr_hash_t **en
> original format pre-upgrade. */
> SVN_ERR(read_val(&val, &curp, endp));
> if (val)
> - entries_format = (apr_off_t)apr_strtoi64(val, NULL, 0);
> + entries_format = (int)apr_strtoi64(val, NULL, 0);

I know the old code didn't do this, but I think the trend is to use
space-before-paren for casts. (But it's part of old-and-busted, so I
don't really think it matters that much. Vermillion.)

-Hyrum

> else
> return svn_error_createf(SVN_ERR_WC_CORRUPT, NULL,
> _("Invalid version line in entries
> file "
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2413440

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2413753
Received on 2009-11-02 13:46:04 CET

This is an archived mail posted to the Subversion Dev mailing list.