[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r39690 - in trunk/subversion: libsvn_subr tests/libsvn_subr

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Wed, 30 Sep 2009 12:14:04 +0200

> -----Original Message-----
> From: lieven.govaerts_at_gmail.com [mailto:lieven.govaerts_at_gmail.com] On
> Behalf Of Lieven Govaerts
> Sent: woensdag 30 september 2009 10:28
> To: dev_at_subversion.tigris.org
> Subject: Re: svn commit: r39690 - in trunk/subversion: libsvn_subr
> tests/libsvn_subr
>
> Bert,
>
>
> what's the difference between upper and lower case drive letters on
> Windows? I thought Windows' use of drive letters was case insensitve?

Windows' use of drive letters is insensitive but if you store the paths containing drive letters in a hashtable or when you compare these paths it is very useful that we actually find the intended value.

Without this fix you could have a perfectly legal absolute path (svn_dirent_is_absolute returned true) that you can't use with any of the WC-NG functions.

Just calling svn_dirent_get_absolute() on all paths -everywhere- is not an option we would like to recommend, as this function is not very cheap.

You will never find these issues by just using svn as that normalizes all paths received from the user via a few specific code paths, but when you use the api directly (e.g. via the client bindings) you will.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2401972
Received on 2009-09-30 12:15:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.