[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

libsvn_wc (status.c) result_pool/scratch_pool

From: Martin Hauner <martin.hauner_at_gmx.net>
Date: Sat, 26 Sep 2009 19:06:35 +0200

Hi,

there is one place in moving libsvn_wc/status.c to result_pool/scratch_pool
where I'm not sure what to do.

status.c has the following function:

static svn_error_t *
close_directory(void *dir_baton,
                 apr_pool_t *scratch_pool)

All pool usages are fine with scratch_pool but a single line looks like a
result_pool:

(currently line 1865)

               eb->anchor_status->ood_last_cmt_author =
                 apr_pstrdup(pool, db->ood_last_cmt_author);

So close_directory would need both pool parameters. But it is an implementation of:

include/svn_delta.h

   svn_error_t *(*close_directory)(void *dir_baton,
                                   apr_pool_t *pool);

I guess we don't want to change this.. ?

-- 
Martin
Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2400681
Received on 2009-09-26 19:06:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.