[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

workqueue example, still tweaking

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 19 Sep 2009 02:11:12 -0400

Hey all,

I'm still working on the workqueue (haha), and am pretty darned close.
I've attached my work-in-progress so you can see the pattern (and
offer early feedback if you'd like!).

This patch still fails:
FAIL: basic_tests.py 12: basic revert command
FAIL: copy_tests.py 24: wc to wc copy with deleted=true items
FAIL: merge_tests.py 40: conflict markers should match the file's eol style
FAIL: update_tests.py 27: conflict markers should match the file's eol style

So I'll be digging into that tomorrow, trying to iron out the final
edges. Then commit, then work on cleaning up from that "known good"
spot.

I'll note that the run_revert() function here is pretty large, but
that over time it will diminish. The workqueue operations are all
about managing *files*. When we move properties into the database, and
add some sanity to the pristine datastore, then I think functions like
this will shrink dramatically. In addition, there is a lot of code
that does the revert using the old entry_t model, but the bulk of
*that* should move into svn_wc__db_op_revert().

Again, your thoughts are welcome, or simply wait for the commit :-)

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2396710

Received on 2009-09-19 08:11:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.