[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r39379 - in trunk/subversion: libsvn_fs_base libsvn_fs_base/bdb libsvn_fs_fs

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Thu, 17 Sep 2009 10:59:19 +0200

> -----Original Message-----
> From: Hyrum K. Wright [mailto:hyrum_at_hyrumwright.org]
> Sent: woensdag 16 september 2009 21:19
> To: svn_at_subversion.tigris.org
> Subject: svn commit: r39379 - in trunk/subversion: libsvn_fs_base
> libsvn_fs_base/bdb libsvn_fs_fs
>
> Author: hwright
> Date: Wed Sep 16 12:19:01 2009
> New Revision: 39379
>
> Log:
> Replace calls to svn_path_join() throughout libsvn_fs_fs and
> libsvn_fs_base.
>
> * subversion/libsvn_fs_base/tree.c,
> subversion/libsvn_fs_base/bdb/env.c,
> subversion/libsvn_fs_base/dag.c,
> subversion/libsvn_fs_fs/tree.c,
> subversion/libsvn_fs_fs/dag.c:
> Switch svn_path_join() for svn_dirent_join() (the filesystem layer
> has no
> concept of a URI).

But it has a concept of repository relative paths, see the broken tests on
the Windows buildbot.

On windows 'c:hi' is a drive relative path to hi in the current directory on
c:, while on posix (and in our repository relative paths) it is a perfectly
valid filename.

It looks like most of the join operations should use svn_uri_join() to make
them work on the c:hi example tested for in our test suite.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2395872
Received on 2009-09-17 10:59:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.