[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v2 Fixed gen_win.py to display Serf library version#

From: Roman Donchenko <DXDragon_at_yandex.ru>
Date: Mon, 14 Sep 2009 03:08:23 +0400

Edmund Wong <ed_at_kdtc.net> писал в своём письме Sun, 13 Sep 2009 21:36:44

> Hi,
> After going over the review by arfrever, lgo and Bert, I've made a
> new patch. Thanks guys.
> Edmund
> Log:
> [[[
> Fixed gen_win.py such that it checks for the presence of the
> Serf library (which it does prior to this patch) and also
> outputs the library version (which is what this patch does).
> * build/generator/gen_win.py
> (_get_serf_version): New function to return the serf library
> version in a 3-tuple format.
> (_find_serf): Added a version check. If the 3-tuple version
> structure has -1 in the first index, the serf library is
> not built; otherwise, the library is set to be built. Then
> a message is displayed informing the user of the results.
> Patch by: Edmund Wong <ed at kdtc.net>
> Suggested by: danielsh
> Review by: arfrever
> lgo
> rhuijben
> ]]]

I think if serf\serf.h exists but version can't be determined, it should
print "unknown version", but still try to enable Serf. That way, it will
be less trouble if some extraneous spaces crop up, or something.


Received on 2009-09-14 01:09:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.