[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39265 - trunk/subversion/include/private

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 13 Sep 2009 02:25:34 -0400

The right answer is to change the definition. There isn't a reason for
a pass-by-value to be const.

On Sun, Sep 13, 2009 at 02:06, Lieven Govaerts <lgo_at_mobsol.be> wrote:
> Author: lgo
> Date: Sat Sep 12 23:06:00 2009
> New Revision: 39265
>
> Log:
> Follow up r39259 with a small fix that should get the Windows
> buildbot back in green.
>
> * subversion/include/private/svn_wc_private.h
>  (svn_wc__node_walk_children): make walk_callback const in
>   the declaration, as it's const in the definition.
>
> Modified:
>   trunk/subversion/include/private/svn_wc_private.h
>
> Modified: trunk/subversion/include/private/svn_wc_private.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/private/svn_wc_private.h?pathrev=39265&r1=39264&r2=39265
> ==============================================================================
> --- trunk/subversion/include/private/svn_wc_private.h   Sat Sep 12 19:41:33 2009        (r39264)
> +++ trunk/subversion/include/private/svn_wc_private.h   Sat Sep 12 23:06:00 2009        (r39265)
> @@ -411,7 +411,7 @@ svn_error_t *
>  svn_wc__node_walk_children(svn_wc_context_t *wc_ctx,
>                            const char *local_abspath,
>                            svn_boolean_t show_hidden,
> -                           svn_wc__node_found_func_t walk_callback,
> +                           const svn_wc__node_found_func_t walk_callback,
>                            void *walk_baton,
>                            svn_depth_t walk_depth,
>                            svn_cancel_func_t cancel_func,
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2394174
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2394180
Received on 2009-09-13 08:25:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.