[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 12 Sep 2009 05:23:39 -0400

Yowza. This patch is spot-on. The comment changes are xlnt, and the
style is perfect. I note that the patch follows precedent of pulling
the two-pools down to its own line in an argument list in a function
call. Very typical of what is seen elsewhere.

And yes... while I said that log.[ch] is headed for the graveyard,
I'll note that hwright is plowing thru the file in order to change a
bunch of callpoints into the lower subsystems. ie. while we're going
to get rid of it eventually, tweaking it now let's us advance the
lower (and upper) levels. Thus, a patch to log.[ch] is very handy.

Martin: sorry for the delay here. The patch looks great, but I doubt
it is going to apply today. Could you update the patch, to be
applicable against trunk, and then I'll review/commit the sucker.

Thanks!
-g

On Fri, Sep 11, 2009 at 21:07, Gavin Baumanis <gavinb_at_thespidernet.com> wrote:
> Ping.
> This submission has not received any follow-up.
>
> Please note the patch is attached to the original post of this thread;
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386500
>
>
> Gavin.
> On 24/08/2009, at 06:52 , Martin Hauner wrote:
>
>> Hi Greg,
>>
>> On 23.08.09 20:04, Greg Stein wrote:
>>> On Sun, Aug 23, 2009 at 11:56, Martin
>>> Hauner<martin.hauner_at_gmx.net>  wrote:
>>>> ...
>>>>> I would suggest files other than log.[ch] -- the loggy subsystem is
>>>>> going to be completely removed over the next six weeks.
>>>>
>>>> Ouch, another wasted hour ;-)
>>>
>>> If you're "close" with a patch, then you may as well wrap it up and
>>> send it to the list. It certainly can't hurt to apply it.
>>
>> Yes, it was attached to my first email. :)
>>
>>
>>> Cheers,
>>> -g
>>>
>>
>>
>> --
>> Martin
>>
>> Subcommander 2.0.0 Beta 4 - http://subcommander.tigris.org
>> a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2386574
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393774
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393824
Received on 2009-09-12 11:23:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.