[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixed gen_win.py to display Serf library version#

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Fri, 11 Sep 2009 13:17:39 +0200

On Fri, Sep 11, 2009 at 11:03 AM, Edmund Wong<ed_at_kdtc.net> wrote:
> Hi,
>
> Given my previous message regarding gen-make.py not outputting
> the Serf library even when it finds it, I have created a patch
> that displays the library version if it finds it.  In actual
> fact, this patch modifies gen_win.py and not gen-make.py.
>
> Unfortunately, there is a caveat for this patch.  It depends
> entirely on the fact that the Serf library's version # will always
> be in serf.h AND that the format is the same; that is,
> the major, minor and patch #s are under individual defined
> constants:
>
> #define SERF_MAJOR_VERSION 0
> #define SERF_MINOR_VERSION 3
> #define SERF_PATCH_VERSION 0
>
> If the library changes the format of getting the version
> #, this patch is broken.

These are part of the API of serf, and serf.h is *the* file that
applications using serf have to include.
So, we will not change this.

Lieven

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2393587
Received on 2009-09-11 13:18:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.