[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: reducing code bloat by removing svnpatch? (except unidiff)

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 28 Aug 2009 15:41:13 +0100

On Wed, Aug 26, 2009 at 05:42:30PM +0200, Bert Huijben wrote:
> > Here is what diffstat has to say about this diff:
> > include/svn_client.h | 67 -
> > include/svn_wc.h | 39
> > libsvn_client/client.h | 11
> > libsvn_client/deprecated.c | 50 -
> > libsvn_client/diff.c | 107 --
> > libsvn_client/merge.c | 3
> > libsvn_client/patch.c | 1744 ----------------------------------
> > ---------
> > libsvn_client/repos_diff.c | 479 -----------
> > libsvn_wc/deprecated.c | 3
> > libsvn_wc/diff.c | 1064 --------------------------
> > svn/diff-cmd.c | 10
> > svn/main.c | 28
> > svn/patch-cmd.c | 4
> > tests/cmdline/patch_tests.py | 267 ------
> > 14 files changed, 50 insertions(+), 3826 deletions(-)
> >
> > Thoughts? Comments? Should we remove this?
> > If not, ideas about how to reduce the bloat?
>
> As noted earlier, we could use skels instead of a reimplementation of the
> svn protocol. Other suggestions include implementing an editor driver
> instead of direct calls into libsvn_wc.
>
> In its current state I think it is a big code bloat that will be hard to
> maintain and I would be +1 on disabling until it is better maintainable.

Any more opinions on this?

Are some people planning to review, or still busy reviewing,
the implementation to make their judgement, and just need some time?

Please post a short note if you are at all interested in this discussion,
otherwise I will assume that people don't care, and apply the patch in
a few days.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388293
Received on 2009-08-28 16:41:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.