[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38973 - in trunk/subversion: include libsvn_subr tests/libsvn_subr

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 28 Aug 2009 11:26:32 +0100

On Fri, Aug 28, 2009 at 10:51:54AM +0100, Stefan Sperling wrote:
> On Fri, Aug 28, 2009 at 03:57:32AM +0300, Daniel Shahaf wrote:
> > So, we create/destroy a pool for *every single line* in the stream?
> > (when a transformation callback is set)
> >
> > Isn't that too expensive? Perhaps this function (line_transformer)
> > should simply take two pool arguments like everyone else?
>
> True. But we would have to convert svn_stream_readline() to dual-pool
> as well. Creating the scratch pool inside of svn_stream_readline() won't
> fix this problem. That's not a small change, but it could be done.
> It's definitely a change that warrants a separate patch.

Nevermind.
Julian found a way to do this, by passing the iterpool of the readline
function to the transformer in r38979.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388215
Received on 2009-08-28 12:27:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.