On Thu, Aug 27, 2009 at 20:10, Blair Zajac<blair_at_orcaware.com> wrote:
> Greg Stein wrote:
>>
>> On Thu, Aug 27, 2009 at 16:47, Blair Zajac<blair_at_orcaware.com> wrote:
>>>
>>> Author: blair
>>> Date: Thu Aug 27 13:47:07 2009
>>> New Revision: 38975
>>>
>>> Log:
>>> Coding style tweak.
>>>
>>> * subversion/include/svn_io.h
>>> (svn_stream_set_line_transformer_callback):
>>> Move the arguments onto their own line so there is no lint
>>> wrapping of a single argument.
>>>
>>> Modified:
>>> trunk/subversion/include/svn_io.h
>>>
>>> Modified: trunk/subversion/include/svn_io.h
>>> URL:
>>> http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_io.h?pathrev=38975&r1=38974&r2=38975
>>>
>>> ==============================================================================
>>> --- trunk/subversion/include/svn_io.h Thu Aug 27 13:44:13 2009
>>> (r38974)
>>> +++ trunk/subversion/include/svn_io.h Thu Aug 27 13:47:07 2009
>>> (r38975)
>>> @@ -765,9 +765,9 @@ svn_stream_set_line_filter_callback(svn_
>>> * @a line_transformer_cb.
>>> * @since New in 1.7. */
>>> void
>>> -svn_stream_set_line_transformer_callback(svn_stream_t *stream,
>>> - svn_io_line_transformer_cb_t
>>> - line_transformer_cb);
>>> +svn_stream_set_line_transformer_callback
>>> + (svn_stream_t *stream,
>>> + svn_io_line_transformer_cb_t line_transformer_cb);
>>
>> That parentheses should not have been pulled down to a second line. It
>> introduces whitespace between the name and paren (no longer allowed,
>> per style), so it doesn't follow current convention. I believe we also
>> have some automated scripts that look for function names, and this
>> will break those (in trunk/build/).
>
> That's the current standard style throughout the code. If we want to change
> it, someone should go through the entire code base and fix it.
There is no current style of a space before a paren. Point me at the
other places, and I'll change them.
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388075
Received on 2009-08-28 08:13:15 CEST