Re: Long argument lines (was: [PATCH] v4. line_transformer callback)

On Thu, Aug 27, 2009 at 20:16, Blair Zajac<blair_at_orcaware.com> wrote:
>...
> Beating a dead horse, but even svn_client.h has this style when I searched
> through the files alphabetically, and for 1.7 too :)
>
>  * @note If there is no blame information for this line, @a revision will be
>  * invalid and @a rev_props will be NULL. In this case @a local_change
>  * will be true if the reason there is no blame information is that the line
>  * was modified locally, In all other cases @a local_change will be false.
>  *
>  * @since New in 1.7.
>  */
> typedef svn_error_t *(*svn_client_blame_receiver3_t)
>  (void *baton,

Probably a cut/paste from its original declaration. That parent should
go up, too.

> While we're nitpicking style, we don't change macros though?
>
> #define svn_error_quick_wrap \
>  (svn_error__locate(__FILE__,__LINE__), (svn_error_quick_wrap))

That is not an arg-taking macro. It is supposed to expand like:

  return svn_error_quick_wrap(some_function(args));

to:

  return (svn_error__locate(...), (svn_error_quick_wrap))(some_function(args))

Sneaky :-)

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388078
Received on 2009-08-28 08:12:58 CEST