[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v4. line_transformer callback

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 27 Aug 2009 13:56:17 -0700

Stefan Sperling wrote:
> On Thu, Aug 27, 2009 at 01:07:20PM -0700, Blair Zajac wrote:
>>> I thought because of no-space-before paren, this would read:
>>>
>>> void
>>> svn_stream_set_line_transformer_callback(
>>> svn_stream_t *stream,
>>> svn_io_line_transformer_cb_t line_transformer_cb)
>>>
>>> Or is this bike-sheddy?
>> It's bike-sheddy, but I'm following convention in the other header files. In
>> particular, look through subversion/include/svn_auth.h.
>
> Hmmm... I chose to put the parenthesis on the same line.
> We can still change it later if needed.

Well, I don't think we should have both when there's precedent for the other.

Blair

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388017
Received on 2009-08-27 22:56:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.