[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] v4. line_transformer callback

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 27 Aug 2009 20:37:46 +0100

On Thu, Aug 27, 2009 at 09:24:53PM +0200, Daniel Näslund wrote:
> if (filtered)
> *stringbuf = svn_stringbuf_create_ensure(0, pool);
> + else if (stream->line_transformer_cb)
> + SVN_ERR(line_transformer(stream, stringbuf, str->data,
> + iterpool));

Passing iterpool here can cause problems, since the result will go
to the caller.

I'll fix this at my end, and test this patch now. Unless more issues
pop up unexpectedly I'll commit it.

Stefan

> else
> *stringbuf = svn_stringbuf_dup(str, pool);

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2387994
Received on 2009-08-27 21:38:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.