[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trouble replacing adm_access in libsvn_client/merge.c (merge_file_changed)

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Tue, 25 Aug 2009 14:52:53 +0200

On Aug 25, 2009, at 2:46 PM, Bert Huijben wrote:

>> -----Original Message-----
>> From: Daniel Näslund [mailto:daniel_at_longitudo.com]
>> Sent: dinsdag 25 augustus 2009 14:17
>> To: dev_at_subversion.tigris.org
>> Subject: Re: Trouble replacing adm_access in libsvn_client/merge.c
>> (merge_file_changed)
>>
>> Thanks Julian for your answers.
>>
>> As I see it, this is the situation:
>>
>> It's not an option to close an adm_access baton and reopen it.
>> To retrieve an already created adm_access baton I need another
>> associated with it or a wc_ctx. Ultimately it's the db I need.
>> BUT the db is not allowed to be known outside of libsvn_wc, not even
>> for
>> this temporary fix.
>>
>> Can I create a function svn_wc_adm_retrieve_with_wc_ctx() or
>> something
>> similar? Right now I can only get a new adm_access from a wc_ctx when
>> outside of libsvn_wc. I can not retrieve an already created
>> adm_access
>> from a wc_ctx.
>
> Yes, please add a svn_wc__adm_retrieve_(with/via/...?)_context()
> helper.
>
> I think that would be a useful helper in more places of
> libsvn_client, until libsvn_wc accepts wc_ctx, abspath everywhere.

Note that we already have a svn_wc__adm_retrieve_internal2() API which
accepts an wc_db and abspath, and just fetches the baton from the db's
set of cached batons. Perhaps this might be of some use. One catch
here is that the *type* of the baton needs to be correct. In other
words, we should return a cached read baton, when the caller asks for
a read/write baton. (I tried making *all* batons read/write at one
point, but that introduces problems of it's own, believe it or not.)

What *I* want to see, and I don't know if we have it or not, is
something which I could call to "go get me an access baton for PATH,
whether you fetch the cached one, or whether you open a new one, I
don't care." Maybe we have that already, or maybe it's just a pipe
dream.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2387056
Received on 2009-08-26 23:56:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.