[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38878 - trunk/subversion/libsvn_auth_gnome_keyring

From: Peter Samuelson <peter_at_p12n.org>
Date: Thu, 20 Aug 2009 09:46:54 -0500

[Peter Samuelson]
> +static void
> init_gnome_keyring(void)
> {
> const char *application_name = NULL;
> application_name = g_get_application_name();
> if (!application_name)
> g_set_application_name("Subversion");
> +
> + /* Ideally we call g_log_set_handler() with a log_domain specific to
> + libgnome-keyring. Unfortunately, at least as of gnome-keyring
> + 2.22.3, it doesn't have its own log_domain. As a result, we
> + suppress stderr spam for not only libgnome-keyring, but for
> + anything else the app is linked to that uses glib logging and
> + doesn't specify a log_domain. */
> + g_log_set_default_handler(log_noop, NULL);
> }

An argument could be made that the g_log_set_default_handler call
should happen inside the if (!application_name), on the theory that if
someone has set the GLib application_name, they're a GUI app and would
want their own console spam.

But I don't know enough about it, so I just did what I did.

-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2385641
Received on 2009-08-20 16:47:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.