[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try)

From: Edmund Wong <ed_at_kdtc.net>
Date: Wed, 19 Aug 2009 09:02:20 +0800

Stefan Sperling wrote:
> On Tue, Aug 18, 2009 at 07:13:14PM +0800, Edmund Wong wrote:
>> Index: subversion/libsvn_subr/eol.c
>> ===================================================================
>> --- subversion/libsvn_subr/eol.c (revision 0)
>> +++ subversion/libsvn_subr/eol.c (revision 0)
>> @@ -0,0 +1,139 @@
>> +/*
>> + * eol.c : generic eol/keyword routines
>
>> +#define APR_WANT_STRFUNC
>> +#include <apr_want.h>
>> +
>> +#include <stdlib.h>
>> +#include <assert.h>
>> +#include <apr_pools.h>
>> +#include <apr_tables.h>
>> +#include <apr_file_io.h>
>> +#include <apr_strings.h>
>> +
>> +/*
>> +#include "svn_string.h"
>> +#include "svn_dirent_uri.h"
>> +#include "svn_path.h"
>> +#include "svn_time.h"
>> +#include "svn_utf.h"
>> +*/
>> +#include "svn_types.h"
>> +#include "svn_error.h"
>> +#include "svn_io.h"
>> +
>> +#include "svn_private_config.h"
>> +#include "private/svn_eol_private.h"
>
> It should still be possible to trim more headers.
> Maybe start with no header at all, and then add just the necessary
> headers to make it compile, one-by-one?

Thanks. I've done that but there is an item that I don't quite
understand. Since this is eol.c, should I not have
#include "private/svn_eol_private.h" in the header? Should it
(being the compiler) complain of a missing header if I were
to leave it out?

I've whittled the headers down to two major ones and the
#include "private/svn_eol_private.h" one, but if I were to
take it out, the program still compiles. Does that mean
it isn't necessary to have his include line?

Thanks

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2385059
Received on 2009-08-19 03:07:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.