[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Moved EOL functions to new libsvn_subr/eol.c

From: Edmund Wong <ed_at_kdtc.net>
Date: Mon, 17 Aug 2009 10:42:53 +0800

Hi,

"One ping only"
- Capt. Ramius.
   HfRO

Is there something missing from this patch? Is the log
ok?

Any help appreciated.

Edmund

> Hi,
>
> This is my first attempt at a 'large' patch
> (in terms of # of files affected).
>
> Edmund
>
> Log:
>
> [[[
>
> Moved the EOL functions from the
> libsvn_subr/subst.c library to libsvn_subr/eol.c
> and from include/svn_subst.h to
> include/private/svn_eol_private.h. This is to
> allow future consolidation of EOL functions to
> be placed in the new files instead of being
> placed all over the place.
>
> Changed patch.c, subst-tests.c and diff-file.c
> to reflect the change in libraries for
> svn_subst_find_eol_start(), svn_subst_detect_eol(),
> and svn_subst_detect_file_eol().
>
> Updated the build.conf to include the new private
> header (svn_eol_private.h).
>
> * build.conf:
> (msvc-export) : Added private\svn_eol_private.h to end of list.
>
> * subversion/libsvn_diff/diff-file.c:
> Include private/svn_eol_private.h"
>
> * subversion/libsvn_subr/eol.c
> New.
>
> * subversion/include/private/svn_eol_private.h
> New.
>
> * subversion/libsvn_subr/subst.c:
> (svn_subst_find_eol_start,
> svn_subst_detect_eol,
> svn_subst_detect_file_eol): Moved ...
>
> * subversion/libsvn_subr/eol.c
> (svn_subst_find_eol_start,
> svn_subst_detect_eol,
> svn_subst_detect_file_eol): ...to here.
>
> * subversion/include/svn_subst.h
> (svn_subst_find_eol_start,
> svn_subst_detect_eol,
> svn_subst_detect_file_eol): Move ...
>
> * subversion/include/private/svn_eol_private.h
> (svn_subst_find_eol_start,
> svn_subst_detect_eol,
> svn_subst_detect_file_eol): ... to here.
>
> * subversion/libsvn_client/patch.c
> Included private/svn_eol_private.h
>
> * subversion/tests/libsvn_subr/subst-test.c
> Included private/svn_eol_private.h.
>
> Patch by Edmund Wong <ed {at} kdtc.net>
> Suggested by: stsp
>
> ]]]
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2382950

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2384189
Received on 2009-08-17 04:53:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.