[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Tests failing on trunk since r38648

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 13 Aug 2009 16:24:32 +0100

Is anyone working on fixing these?

FAIL: external_tests.py 16: place a file external into a directory external.
FAIL: switch_tests.py 18: switch shouldn't allow changing repos root
FAIL: switch_tests.py 21: forced switch detectes tree conflicts.

These tests are failing, both in my own testing (on SuSE GNU/Linux) and
on the debian build-bot
<http://crest.ics.uci.edu/buildbot/builders/i686-debian-sarge1%20shared%
20gcc-3.3.5/builds/1145>, since last Sunday.

(All the other build-bots have been broken for much longer :-( )

The failures started after the following commit:

All Changes
     1. Changed by: rhuijben
        Changed at: Sun 09 Aug 2009 05:30:10
        Revision: 38648
        
        Changed files:
        
              * subversion/libsvn_client/update.c
              * subversion/libsvn_client/client.h
              * subversion/libsvn_client/checkout.c
              * subversion/libsvn_client/externals.c
              * subversion/libsvn_client/copy.c
              * subversion/libsvn_client/deprecated.c
        Comments:
        Connect the access batons used for updating and checking out to
        the working copy context as preparation for fixing a few Windows test
        failures on externals.
        
        * subversion/libsvn_client/checkout.c
          (svn_client__checkout_internal): Add subcheckout argument and
            pass it to update requests.
          (svn_client_checkout3): Updated for added argument.
        
        * subversion/libsvn_client/client.h
          (svn_client__update_internal): Add argument.
          (svn_client__checkout_internal): Add argument.
        
        * subversion/libsvn_client/copy.c
          (repos_to_wc_copy_single): Updated for added argument.
        
        * subversion/libsvn_client/deprecated.c
          (svn_client_update, svn_client_checkout2, svn_client_checkout):
            Updated for api changes.
        
        * subversion/libsvn_client/externals.c
          (switch_dir_external): Update and checkout as inner operations.
          (handle_external_item_change): Checkout as inner operation.
        
        * subversion/libsvn_client/update.c
          (svn_client__update_internal): Don't try to open anchored if running
            as inner operation.

See also this follow-up commit:

[[[
Author: rhuijben
Date: Sun Aug 9 08:47:49 2009
New Revision: 38654

Log:
Following up on r38648, also connect the access batons of switch operations
to the wc_ctx. This fixes the externals tests on Windows and allows provides
more information on the current Unix buildbot failures.

* subversion/libsvn_client/client.h
  (svn_client__switch_internal): Add argument

* subversion/libsvn_client/deprecated.c
  (svn_client_switch): Updated for api changes.

* subversion/libsvn_client/externals.c
  (switch_dir_external): Switch as inner operation.
  (switch_file_external): Switch as normal operation.

* subversion/libsvn_client/switch.c
  (svn_client__switch_internal): Add argument. Open all
    access batons except one very short living in the wc_ctx.
  (svn_client_switch2): Updated for api changes.
]]]

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2383328
Received on 2009-08-13 17:24:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.