[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use context_t for svn_wc_cleanup3

From: Paul Burba <ptburba_at_gmail.com>
Date: Thu, 13 Aug 2009 10:58:52 -0400

On Thu, Aug 13, 2009 at 10:46 AM, Julian Foad<julianfoad_at_btopenworld.com> wrote:
> On Thu, 2009-08-13 at 16:23 +0200, Daniel Näslund wrote:
>> Hi!
>>
>> [ I could not send this message through my ordinary MUA, mutt.
>> My webmail does unfortunately encode all attachments as binary
>> data. Sorry. ]
>>
>> I have run make check with three FAILs:
>> external_tests.py 16: place a file external into a directory external.
>> switch_tests.py 18: switch shouldn't allow changing repos root
>> switch_tests.py 21: forced switch detectes tree conflicts.
>>
>> Reverted all changes, recompiled and the three tests still failed! Can
>> anyone confirm that those tests are failing on trunk?
>
> Yes, I confirm these are failing, both in my own testing and on the
> debian build-bot
> <http://crest.ics.uci.edu/buildbot/builders/i686-debian-sarge1%20shared%
> 20gcc-3.3.5/builds/1145>, since last Sunday.
>
> - Julian

I was just looking at the the switch test failures. Both are failing
on Window too, but interestingly the switch fails correctly (i.e. with
no segfault) if the cwd is no higher than the WC's immediate parent:

C:\SVN\src-trunk\Release\subversion\tests\cmdline\svn-test-work\working_copies>svn
switch "file:///C%3A/SVN/src-trunk/Debug/subversion/tests/cmdline/svn-test-work/repositories/switch_tests-18.other/A"
switch_tests-18\A
..\..\..\subversion\libsvn_client\switch.c:180: (apr_err=170009)
..\..\..\subversion\libsvn_client\ra.c:491: (apr_err=170009)
..\..\..\subversion\libsvn_ra\ra_loader.c:497: (apr_err=170009)
..\..\..\subversion\libsvn_ra\ra_loader.c:497: (apr_err=170009)
svn: Repository UUID '40da6a90-8424-aa46-b11c-ee91a6e53134' doesn't
match expected UUID '6f764266-4b7f-9646-a0bd-7e8d6c022d56'

Go higher than the immediate parent (as the test suite does) and boom:

C:\SVN\src-trunk\Release\subversion\tests\cmdline\svn-test-work>svn
switch "file:///C%3A/SVN/src-trunk/Debug/subversion/tests/cmdline/svn-test-work/repositories/switch_tests-18.other/A"
working_copies\switch_tests-18\A
..\..\..\subversion\libsvn_client\switch.c:180: (apr_err=170009)
..\..\..\subversion\libsvn_client\ra.c:491: (apr_err=170009)
..\..\..\subversion\libsvn_ra\ra_loader.c:497: (apr_err=170009)
..\..\..\subversion\libsvn_ra\ra_loader.c:497: (apr_err=170009)
svn: Repository UUID '40da6a90-8424-aa46-b11c-ee91a6e53134' doesn't
match expected UUID '6f764266-4b7f-9646-a0bd-7e8d6c022d56'
This application has halted due to an unexpected error.
A crash report and minidump file were saved to disk, you can find them here:
C:\DOCUME~1\pburba\LOCALS~1\Temp\svn-crash-log20090813093953.log
C:\DOCUME~1\pburba\LOCALS~1\Temp\svn-crash-log20090813093953.dmp
Please send the log file to svn-breakage_at_subversion.tigris.org to help
us analyse
and solve this problem.

NOTE: The crash report and minidump files can contain some sensitive information
(filenames, partial file content, usernames and passwords etc.)

Looks like r38654* was the offending revision, specifically the change
in libsvn_client/switch.c:svn_client__switch_internal() where
svn_wc__adm_open_anchor_in_context() replaced
svn_wc_adm_open_anchor(). Trying out Daniel's patch right now.

Paul

* Bert - Have you looked into this at all?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2383317
Received on 2009-08-13 16:59:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.