[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Use context_t for svn_wc_cleanup3

From: Daniel Näslund <daniel_at_longitudo.com>
Date: Thu, 13 Aug 2009 16:23:05 +0200

Hi!

[ I could not send this message through my ordinary MUA, mutt.
My webmail does unfortunately encode all attachments as binary
data. Sorry. ]

I have run make check with three FAILs:
external_tests.py 16: place a file external into a directory external.
switch_tests.py 18: switch shouldn't allow changing repos root
switch_tests.py 21: forced switch detectes tree conflicts.

Reverted all changes, recompiled and the three tests still failed! Can
anyone confirm that those tests are failing on trunk?

I have replaced all occurences of svn_wc_cleanup2 with cleanup3 in
libsvn_client. Is it bad to do two different things in one patch? Since
replacing all cleanup2 means that the wrapper in deprecated.c will not
be tested?

[[[
Use svn_wc_context_t and absolute paths in svn_wc_cleanup3. Make
libsvn_client use svn_wc_cleanup3. Remove diff3_cmd parameter.

* subversion/include/svn_wc.h
  (svn_wc_cleanup3): New.
  (svn_wc_cleanup2): Deprecate.

* subversion/libsvn_wc/deprecated.c
  (svn_wc_cleanup2): Reinplement as a wrapper.

* subversion/libsvn_wc/log.c
  (svn_wc_cleanup3): New. Use absolute paths. No diff3_cmd. Add
    svn_wc_context_t parameter
  (svn_wc_cleanup2): Remove.

* subversion/libsvn_client/cleanup.c
  (svn_client_cleanup): Use svn_wc_cleanup3. Remove use of diff3_cmd
]]]

Mvh
Daniel Näslund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2383303

Received on 2009-08-13 16:23:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.