[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38698 - trunk/subversion/svnlook

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 13 Aug 2009 01:41:14 +0300 (Jerusalem Daylight Time)

Stefan Sperling wrote on Wed, 12 Aug 2009 at 23:26 +0100:
> On Wed, Aug 12, 2009 at 10:30:58AM -0700, Paul T. Burba wrote:
> > Author: pburba
> > Date: Wed Aug 12 10:30:58 2009
> > New Revision: 38698
> >
> > Log:
> > Follow-up to r38621, fix svnlook_tests.py 3 and 9 failures on Windows.
> >
> > * subversion/svnlook/main.c
> > (display_prop_diffs): Writing to stdout via svn_cmdline_printf() and then
> > getting a stream for stdout via svn_stream_for_stdout() and writing to
> > that stream can cause unpredictable ordering of the output when redirecting
> > svnlook's stdout (actually in my testing it is always and consistently
> > mis-ordered, but I'm uncertain that will always be true). This can be
> > avoided by flushing stdout prior to obtaining the stream.
>
> Paul, thanks a million! I took a brief look at the failures a few days
> ago and could not figure out what the problem was (I thought it was
> maybe related to line-endings). I was gonna look into this again, but I
> guess I never would have figured out that flushing stdout was the fix!

r32019 :-)

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2383066
Received on 2009-08-13 00:41:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.