[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_svn replay-range + svnsync + mod_dav_svn = corrupted revisions!

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Tue, 11 Aug 2009 09:41:43 -0500

This is a pretty serious set of bugs.

A recap for the impatient: if mod_dav_svn throws an error during an
svnsync commit at *any time*, then this buggy combo of libsvn_ra_svn
and svnsync defects causes the half-written transaction to be
committed rather than aborted! If you keep running 'svnsync sync',
future deltas will fail to apply, and more and more incomplete
transactions will *continue* to be committed. (We discovered this bug
when we noticed a project on googlecode (reactos-mirror) which
essentially had 27000 revisions, nearly all of which were
busted/incomplete.)

Who is vulnerable to this bug? Anyone running 'svnsync sync' from
svnserve to mod_dav_svn, using svnsync 1.5.x or later. That's a
potentially large audience.

I'm happy to try and patch ra_svn and svnsync right now, but the
question is, how soon until the fixes go out in 1.6.x? Are they worth
doing a 1.5.x release for?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2382503
Received on 2009-08-11 16:42:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.