[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Commit with huge log message

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Tue, 11 Aug 2009 14:42:27 +0530

Hi,

I tried committing a small change to http://svn.collab.net/repos/svn/trunk but
got irrelevant errors, since the log message was 14MB in size (no I didn't
intent to put such a big log message, but it revealed this issue). This was
observed both over neon and serf.

Here is what I got:

For Neon,
<snip>
$ ~/subversion-dev/builds/pure-trunk-neon/bin/svn ci -F /tmp/log.txt
../subversion/svn/commit-cmd.c:142: (apr_err=175008)
../subversion/libsvn_client/commit.c:854: (apr_err=175008)
svn: Commit failed (details follow):
../subversion/libsvn_ra_neon/props.c:1158: (apr_err=175008)
svn: At least one property change failed; repository is unchanged
../subversion/libsvn_ra_neon/util.c:613: (apr_err=175002)
svn: PROPPATCH of
'/repos/svn/!svn/wbl/927ed5ba-a9c3-49a4-9772-5e64216fd89e/38669': Could not
send request body: connection was closed by server (https://svn.collab.net)
</snip>

For serf,
<snip>
$ svn ci -F /tmp/log.txt
../subversion/svn/commit-cmd.c:142: (apr_err=20014)
../subversion/libsvn_client/commit.c:854: (apr_err=20014)
svn: Commit failed (details follow):
../subversion/libsvn_client/commit_util.c:1614: (apr_err=20014)
../subversion/libsvn_delta/path_driver.c:173: (apr_err=20014)
../subversion/libsvn_ra_serf/commit.c:1264: (apr_err=20014)
../subversion/libsvn_ra_serf/commit.c:762: (apr_err=20014)
../subversion/libsvn_ra_serf/util.c:568: (apr_err=20014)
svn: Error running context: Internal error
Segmentation fault
</snip>

At a first glance I couldn't make out the reason for the error. So shouldn't we
give a more pleasing error message?

Also, the above shows that there is a limit for the size of log message, do
anyone know what is the maximum size of log message that can be committed. If
we do have a limit, then IMO it should be caught in libsvn_client and errored
out before we even attempt to contact the server as in the above case.

Thoughts?

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2382390
Received on 2009-08-11 11:12:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.