[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38429 - in trunk/subversion: libsvn_wc tests/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 8 Aug 2009 19:34:50 +0200

On Thu, Jul 16, 2009 at 01:32, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_wc/wc-metadata.sql  Wed Jul 15 16:32:55 2009        (r38429)
> @@ -311,13 +311,13 @@ CREATE TABLE ACTUAL_NODE (
>   properties  BLOB,
>
>   /* ### do we want to record the revnums which caused this? */
> +  /* ### also, shouldn't these be absolute paths?
> +     ### they aren't currently, but that would be more consistent with other
> +     ### columns. (though it would require a format bump) */

Nope. We only have an abspath in the WCROOT table. Everything else is
a local_relpath, which I believe is Proper for these columns.

And yes, I'd agree that is a format bump. In theory. In actuality,
they are a simple filename, but in per-dir semantics, that is *also* a
local_relpath. IOW, the only real *data* change is when we move to
one-dir semantics. In the meantime, I believe you can start
propagating the notion of local_relpath.

Hmm. Just realized: the OUT params from read_info maybe "should" be
abspath values. Thoughts?

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381646
Received on 2009-08-08 19:35:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.