[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38322 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 7 Aug 2009 19:26:32 +0200

On Thu, Jul 2, 2009 at 23:41, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_client/copy.c       Thu Jul  2 14:41:20 2009        (r38322)
>...
>   /* Get a fresh copy of the pre-existing state of the WC's mergeinfo
>      updating it. */
> -  SVN_ERR(svn_client__parse_mergeinfo(&wc_mergeinfo, entry, target_wcpath,
> +  SVN_ERR(svn_client__parse_mergeinfo(&wc_mergeinfo, entry, target_abspath,
>                                       FALSE, adm_access, ctx, pool));

That function isn't specified as taking an abspath. It "happens" to
work, it seems. But that path leads to eventual problems :-P

Looking at parse_mergeinfo(), it does some crazy stuff to fetch a
single property. There is a comment about some day maybe doing it
another way, but I'm doubting that. Until there is something more
specific, then I think it can just be changed to fetch the property
directly. And that *does* specify an abspath for a parameter.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381397
Received on 2009-08-07 19:27:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.