[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38254 - in trunk/subversion: include libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 7 Aug 2009 18:19:07 +0200

On Tue, Jun 30, 2009 at 00:02, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
> Author: hwright
> Date: Mon Jun 29 15:02:55 2009
> New Revision: 38254
>
> Log:
> Rev the property getting API to use a abspath and a wc_context.
>
> [ Note: nothing except the backward compat wrapper currently

Unfinished note here...

>...
> +++ trunk/subversion/libsvn_wc/props.c  Mon Jun 29 15:02:55 2009        (r38254)
>...
> @@ -1799,10 +1798,10 @@ svn_wc_prop_get(const svn_string_t **val
>                                _("Property '%s' is an entry property"), name);
>     }
>
> -  SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
> +  SVN_ERR(svn_wc__internal_propget(value, name, local_abspath, wc_ctx->db,
> +                                   result_pool, scratch_pool));
>
> -  return svn_error_return(svn_wc__internal_propget(value, name, local_abspath,
> -                                                   db, pool, pool));
> +  return SVN_NO_ERROR;
>  }

Any reason not to stick to: return svn_error_return(... ?

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381366
Received on 2009-08-07 18:19:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.