On Tue, Jul 28, 2009 at 6:49 AM, David Glasser<glasser_at_davidglasser.net> wrote:
> On Mon, Jul 27, 2009 at 9:12 PM, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
>> On Jul 27, 2009, at 10:31 AM, Julian Foad wrote:
>>
>>> On Mon, 2009-07-20 at 23:23 -0400, James Abbatiello wrote:
>>>> Currently svntest parses the output of `svn proplist --verbose` to
>>>> retrieve the list of properties for an item. When the output format
>>>> of this command changed between 1.5 and 1.6, svntest was updated to
>>>> understand the new format (but only the new format). As a result you
>>>> need matched versions of svn and svntest in order for it to function
>>>> correctly. It is not forward or backward compatible.
>>>>
>>>> This is apparently not a problem for development of Subversion but
>>>> cvs2svn pulls in svntest as an external and uses it with whatever
>>>> version of svn that the user currently has installed. Things break
>>>> when the user doesn't have the expected version installed.
>>>>
>>>> It would be nice if svntest would be able to query properties
>>>> successfully even when run with 1.5. Writing a parser that
>>>> understands both text formats seems difficult but there's the '--xml'
>>>> option to output in XML format and it seems made for just this
>>>> situation. Is there something precluding the use of the XML format
>>>> for svntest?
>>>
>>> I don't think there is anything precluding the use of "svn proplist
>>> --xml" for svntest's property-checking functions.
>>
>> Nor do I, just as long as we make sure to still test the "standard"
>> output somewhere in the testsuite.
prop_tests.py covers most of 'svn proplist', except ... 'svn proplist --xml'.
>
> The Python versions we support ship with an XML parser, right?
The test suite already tests the output of 'svn diff --summarize
--xml' in svntest/actions.py using expat, so we're ok for python 2.4
<= version < 3.0.
Lieven
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2376905
Received on 2009-07-30 13:32:47 CEST