[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]commit-test-py

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 16 Jul 2009 15:40:36 +0100

HuiHuang wrote:
> Hey,
>
> log message:
>
> [[[
>
> * subversion/tests/cmdline/commit_tests.py
> Tweak some mistake.
> We should verify 'A/B/lambda' status = 3, not 2.
>
> And we remove XFail() from test commit_multiple_wc_nested and
> commit_multiple_wc.
> ]]]

Hi HuiHang.

Please start every log message with a sentence or two that describes the
purpose of the patch: what bug does it fix or what enhancement does it
make? From your message above, I can't tell whether this patch is
changing the tests to expect the new behaviour that your other patches
will introduce, or whether it is supposed to fix a bug that already
exists, or something else.

It looks like this patch does two things: remove XFail because the
behaviour being tested is now implemented (or rather, will be
implemented by your other patches); and fix a minor error in the tests'
expectations.

For example, maybe you want to say:

"""
  Here is a patch to update the tests to match the new behaviour
  introduced by my "commit-cmd" patch. It should be applied after
  that patch.

  Here is the log message:
  [[[
    Remove XFail from some commit tests because the desired behaviour
    has now been introduced (in r#####). Correct a minor error in those
    tests.
    
    * subversion/tests/cmdline/commit_tests.py
      (commit_multiple_wc_nested, commit_multiple_wc): Correct the expected
        WC revision number of 'A/B/lambda'.
      (test_list): Remove XFail() from test commit_multiple_wc_nested
        and commit_multiple_wc.
  ]]]
"""

If this patch goes together with your "commit-cmd" patch, it is probably
better to send just one patch that includes both this and the commit-cmd
changes. Then it would be clear that the changes go together.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2371770
Received on 2009-07-16 16:41:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.