[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch Manager additional task?

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Wed, 15 Jul 2009 15:01:43 -0600

On Jul 13, 2009, at 6:27 AM, Stefan Sperling wrote:

> On Mon, Jul 13, 2009 at 03:21:27AM +1000, Gavin Baumanis wrote:
>> I ping the list asking for review etc.
>> But it still doesn't get any interest from a full committer.
>>
>> Normally I would send it to the issue tracker.
>> At this point - and not before, do I propose that the PM could
>> instead, commit the change.
>
> I think the patch should be filed into the issue tracker with
> a milestone of either the next .0 release or the next patch release.
>
> If the patch does not address a serious bug in a released version,
> then it should be scheduled for the next .0 release.
> If the patch does address a bug which exists in a released version
> of Subversion, then the issue should be scheduled for the next
> patch release.

This is exactly what should happen. The role of the patch manager is
to ensure that no patch is left behind. Either a committer commits
the patch, it gets sent back for further review, or a reviewed patch
is left to languish. In the last case, I issue of type PATCH should
be opened, and periodically, committers troll through the issue
tracker reviewing or committing such patches.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2371629
Received on 2009-07-16 01:31:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.